[mdatagen] Add variable for metric name #12531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12531 +/- ##
=======================================
Coverage 92.21% 92.21%
=======================================
Files 469 469
Lines 25368 25378 +10
=======================================
+ Hits 23392 23402 +10
Misses 1568 1568
Partials 408 408 ☔ View full report in Codecov by Sentry. |
|
I will address the contrib test issue by updating otel PR once this is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add variable for metric name in mdatagen, accessing via
metadata.DefaultMetricsBuilderConfig()Link to tracking issue
Fixes #12459
Testing
n/a
Documentation
Added